Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: checkbox-group): invalid disabled in dataSource #827

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

<template>
    <IxCheckboxGroup v-model:value="value" :dataSource="dataSource" buttoned  />
</template>

<script setup lang="ts">
import { ref } from 'vue'

const value = ref(['beijing'])

const dataSource = [
  { label: 'Beijing', value: 'beijing', disabled: true },
  { label: 'Shanghai', value: 'shanghai' },
  { label: 'Guangzhou', value: 'guangzhou' },
  { label: 'Shenzhen', value: 'shenzhen' },
]
</script>

disabled 无效

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 30, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #827 (c663f76) into main (74fb409) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c663f76 differs from pull request most recent head 3764bc4. Consider uploading reports for the commit 3764bc4 to get more accurate results

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files         509      509           
  Lines       13127    13127           
  Branches     3181     3181           
=======================================
  Hits        11251    11251           
  Misses       1875     1875           
  Partials        1        1           
Impacted Files Coverage Δ
packages/components/checkbox/src/Checkbox.tsx 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fb409...3764bc4. Read the comment docs.

@danranVm danranVm merged commit 0f43a09 into IDuxFE:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants